Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python-version-specific deps in poetry #523

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support Python-version-specific deps in poetry #523

wants to merge 2 commits into from

Conversation

xhochy
Copy link
Contributor

@xhochy xhochy commented Jan 15, 2024

Poetry also supports dependencies depending on the Python version. I have encountered this in the nannyml package.

@xhochy xhochy requested a review from a team as a code owner January 15, 2024 20:00
@marcelotrevisani
Copy link
Member

could you please rebase? It seems there are a couple tests failing

@jakirkham
Copy link
Member

Maybe we should configure Grayskull with this GitHub setting

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/keeping-your-pull-request-in-sync-with-the-base-branch#updating-your-pull-request-branch

@jakirkham
Copy link
Member

In particular think the setting is here

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-suggestions-to-update-pull-request-branches

@marcelotrevisani
Copy link
Member

marcelotrevisani commented Jan 22, 2024 •
edited
Loading

That is already enabled :)
It is because we have a conflict that needs to be addressed first.

@jakirkham
Copy link
Member

Ah ok. I can't see as I don't have permissions here 😅

@xhochy
Copy link
Contributor Author

xhochy commented Jan 23, 2024

The tests don't pass. I realised once I have pushed this, that the problem will be much more complex.

@ytausch
Copy link

ytausch commented Jul 19, 2024

xref #463 #535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xhochy @marcelotrevisani @jakirkham @ytausch